search

solid-contrib / solid-node-client

a nodejs client for Solid
MIT License
20 stars 8 forks source link

Use 'master' instead of 'main'? #2

Closed michielbdejong closed 3 years ago

michielbdejong commented 3 years ago

Hi @jeff-zucker, Would it be OK to rename the 'main' branch to 'master', for consistency?

Cheers, Michiel

jeff-zucker commented 3 years ago

Done, thanks

jeff-zucker commented 3 years ago

Hmm, I just checked on github and now understand what happened here. It may be something to consider for all our libraries, though it would be a pain. Basically, github, like many tech companies, out of respect for the Black Lives Matter movement, is eliminating all language that uses the "master/slave" analogy. So github's default branch is now called main by default.

jeff-zucker commented 3 years ago

I don't know how this will impact your scripts but check this out : https://github.com/github/renaming. Among other things it says "We've updated GitHub.com to redirect links that contain the deleted branch name master to the corresponding link in the repository's new default branch."

bourgeoa commented 3 years ago

It also say don't rename now and wait later ...

jeff-zucker commented 3 years ago

Yes it does, so I am leaving main as the default for the time being.

michielbdejong commented 3 years ago

Thanks for looking into this!

https://gitter.im/solid/solidos?at=5f9fe160c6fe0131d4cdd98e