search

solid-contrib / web-access-control-tests

Tests if a Solid server implements web access control correctly
MIT License
2 stars 5 forks source link

Minor readability issue with filenames of test resources #33

Open edwardsph opened 3 years ago

edwardsph commented 3 years ago

The read*, update and delete tests use test.txt when setting up turtle resources. Elsewhere it is test.ttl. It doesn't affect whether or not the tests work but might help readability if the filenames were consistent with the content types.

bourgeoa commented 3 years ago

We may consider that these tests are doing 2 things at the same time and that it is OK or relabel them to explicitly state that they update/delete resources with filenames ending with a different media type then the content-type, or add tests so that they do only one thing at a time

edwardsph commented 3 years ago

Personally, I think for traceability reasons a test should focus on one thing at a time. I suspect the filename difference was a simple copy & paste oversight in this case not a deliberate purpose of the test. Each test should be clear about its purpose.