solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
18 stars 4 forks source link

sd-button-group -> deprecate figma comp? #1158

Open coraliefeil opened 4 weeks ago

coraliefeil commented 4 weeks ago

Problem

In Figma we have a sd-button-group, in code we don’t have that. -> Delta

We’ve learned a lot along the way. And since this group comp is one of the earlier comps and we implemented things like that as samples later on, I think it is time to do some refactoring here.

Should we deprecate the group comp and in favor of samples?

-> Needs discussion

DoR

DoD

coraliefeil commented 4 weeks ago

I’ll assign this to you @yoezlem FYI prior to a pre-refinement.

yoezlem commented 4 days ago

Lets deprecate the sd-button-group and add a sample instead.

@van-nguyen-ht, could you check with @MartaPintoTeixeira for clarity if we are using the sd-button-group somewhere else?

van-nguyen-ht commented 1 day ago

@yoezlem @MartaPintoTeixeira In the Solid library, the sd-button-group is only used in sd-dialog and forms samples. CMS library probably more. Though the component were not built with multi-slot, breaking changes will happen.