docs: sd-select docs [skip chromatic]

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.

https://solid-design-system.fe.union-investment.de/x.x.x/storybook/

Other

19 stars 3 forks source link

docs: sd-select docs [skip chromatic] #1289

Closed smfonseca closed 2 weeks ago

smfonseca commented 1 month ago

Description:

Definition of Reviewable:

[ ] Documentation is created/updated
[ ] Migration Guide is created/updated
[ ] E2E tests (features, a11y, bug fixes) are created/updated
[ ] Stories (features, a11y) are created/updated
[ ] relevant tickets are linked

coraliefeil commented 2 weeks ago

Figma docs is refined Code is reviewed Figma template can be done by @MartaPintoTeixeira

coraliefeil commented 2 weeks ago

Figma Template is refinded displaying real content.

Updating existing template to real content can be done at a later point of time. We could also just keep existing grouping options for now ...

smfonseca commented 2 weeks ago

@coraliefeil I've removed the previous templates and added the new one, please check

MartaPintoTeixeira commented 2 weeks ago

On the template we have this copy: "Label: Additionally a label can be shown for each option group. Divider: Use sd-divider to group option items visually. Accessibility hint: group labels will be neglected by most assistive devices."

MartaPintoTeixeira commented 2 weeks ago

On the template I think we dont need to say: "Example of a sd-select with grouping options." as the title is self explanatory

MartaPintoTeixeira commented 2 weeks ago

On the Related templates can we add a link sayins: "Select with Tooltip" bellow the "Select Grouping" link. And link it to the respective Tooltip section?

smfonseca commented 2 weeks ago

@MartaPintoTeixeira @coraliefeil updates done. For the "Select with tooltip" template, in figma we have the green line signaling the current selected value. To replicate I need to set the initial value to one of the options. Is it ok to leave the initial value empty or do you prefer to have one option already set?

coraliefeil commented 2 weeks ago

@MartaPintoTeixeira @coraliefeil updates done. For the "Select with tooltip" template, in figma we have the green line signaling the current selected value. To replicate I need to set the initial value to one of the options. Is it ok to leave the initial value empty or do you prefer to have one option already set?

You can leave it empty. All good.

coraliefeil commented 2 weeks ago

Approved