fix: 🤔 sd-teaser-media variant title alignment - Githubissues

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.

https://solid-design-system.fe.union-investment.de/docs/

Other

21 stars 4 forks source link

fix: 🤔 sd-teaser-media variant title alignment #1296

Closed MartaPintoTeixeira closed 1 month ago

MartaPintoTeixeira commented 2 months ago

Current behavior

Issues: On storybook the variant "Gradient-light" is named "Gradient-white"

Expected behavior

Variant should be named "Gradient-light" as it is in FIGMA.

Steps to reproduce

https://solid-design-system.fe.union-investment.de/x.x.x/storybook/index.html?path=/docs/components-sd-teaser-media--docs

Technical Information

DoR

[x] Item has business value
[x] Item has been estimated by the team
[x] Item is clear and well-defined
[x] Item dependencies have been identified

DoD

[ ] Documentation has been created/updated (if applicable)
[ ] Migration Guide has been created/updated (if applicable)
[ ] Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
[ ] Relevant stories (Features, A11y) are created/updated
[ ] Implementation works successfully on feature branch

karlbaumhauer commented 2 months ago

@coraliefeil pls check if the secondpoint is still valid.

coraliefeil commented 1 month ago

If we don’t change the default variant it is not a breaking change IMO @yoezlem that’s why I removed the label.

mariohamann commented 1 month ago

It is a breaking change, as if someone set gradient-white in the past, this won't work anymore.

coraliefeil commented 1 month ago

Ah ok. Understood. THX