solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
19 stars 3 forks source link

feat: ✨add sd-leadtext to sd-prose #1304

Closed christophsaile closed 1 month ago

christophsaile commented 1 month ago

User Story

As a User of the Solid Design System, I would like to have the option to use the sd-leadtext inside the sd-prose, so that I can fulify the requested design.

Suggested Solution

when the sd-leadtext class is used on a element inside the sd-prose, the leadtext should still be styled as a sd-leadtext.

Leadtexts are supported by the tailwind typography component as well: https://github.com/tailwindlabs/tailwindcss-typography

CMS Figma Link: https://www.figma.com/design/QjYmW5zZuGLdnSibmDD2Fo/UI-CMS-Library?node-id=2871-6621&t=beKLVDtiqUdFnGrt-0

image

Current Behaviour

inverted state is not working + the font-size is not correct:

image

Subtasks

DoR

DoD

christophsaile commented 1 month ago

Hey @coraliefeil, can you please have a look at this issue? I am currently working on a ticket that requires the usage of the sd-leadtext inside the sd-prose. I already talked with @mariohamann, and he agreed that this feature is valuable. Furthermore, we already found a technical solution for this requirement. Can you adjust the sd-prose design file and include the leadtext option, or do you see anything that speaks against this feature?

coraliefeil commented 1 month ago

Yes, we can adjust sd-prose accordingly @christophsaile

coraliefeil commented 1 month ago

Yes, we can adjust sd-prose accordingly @christophsaile

Sample done

Docs done