feat: ✨ improve copyright visibility - Githubissues

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.

https://solid-design-system.fe.union-investment.de/x.x.x/storybook/

Other

19 stars 3 forks source link

feat: ✨ improve copyright visibility #1309

Open auroraVasconcelos opened 1 month ago

auroraVasconcelos commented 1 month ago

Current behavior

The existing version of the copyright text is white, having a low contrast with light backgrounds/images. (https://github.com/solid-design-system/solid/pull/1280#issuecomment-2298637967)

Expected behavior

It is possible to choose between two types of font colors to improve contrast making it more readable.

Suggested solution

Implement the style component in figma serving as a helper component and utilize it in sd-brandshape, sd-teaser-media, etc.
Add text color choices text.black, text.white
Add text shadow boolean (As we have it now ... only available for text.white)

Technical Information

DoR

[ ] Item has business value
[ ] Item has been estimated by the team
[ ] Item is clear and well-defined
[ ] Item dependencies have been identified

DoD

[ ] Documentation has been created/updated (if applicable)
[ ] Migration Guide has been created/updated (if applicable)
[ ] Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
[ ] Relevant stories (Features, A11y) are created/updated
[ ] Implementation works successfully on feature branch )

1sopropanol commented 1 month ago

My account has been stolen, and they send junk emails everywhere. I've changed my password. Sorry for what you've received. 1sopropanol