fix: 🤔 add label to close button in sd-dialog - Githubissues

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.

https://solid-design-system.fe.union-investment.de/x.x.x/storybook/

Other

19 stars 3 forks source link

fix: 🤔 add label to close button in sd-dialog #1320

Closed christophsaile closed 1 month ago

christophsaile commented 1 month ago

Current behavior

Currently the close button in the sd-dialog does not have a label.

Expected behavior

The close button should have a label that describes its action -> close

Steps to reproduce

Technical Information

DoR

[ ] Item has business value
[ ] Item has been estimated by the team
[ ] Item is clear and well-defined
[ ] Item dependencies have been identified

DoD

[ ] Documentation has been created/updated (if applicable)
[ ] Migration Guide has been created/updated (if applicable)
[ ] Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
[ ] Relevant stories (Features, A11y) are created/updated
[ ] Implementation works successfully on feature branch