solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
19 stars 3 forks source link

fix: 🤔 sd-radio-button does not accept "md" size for radio-button #1326

Open Vahid1919 opened 2 weeks ago

Vahid1919 commented 2 weeks ago

Current behavior

You cannot set sd-radio-group as size ="md" (options are 'lg', 'sm'). This means that even though sd-radio-button has a "md" size, there is no way to set this since sd-radio-button does not accept "md" as a size option and will reset all sizes set on the child sd-radio-buttons to the default "lg"

Image

Expected behavior

You can set the sd-radio-group's size as "md", in order to showcase medium sizes sd-radio-buttons

Image

Steps to reproduce

Take a look at the Docs page of sd-radio-group and sd-radio-button, the group lacks a size "md" making sd-radio-buttons for this size incompatible.

Technical Information

DoR

DoD

yoezlem commented 4 days ago

@coraliefeil why do we only have sm and lg in the group? it would be much easier in code to add a md in the group, otherwise we need some different logic for sd-radio-button with sd-radio-group.