solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
19 stars 3 forks source link

docs: sd-navigation-item docs [skip chromatic] #1332

Closed auroraVasconcelos closed 2 weeks ago

auroraVasconcelos commented 1 month ago

Description:

Definition of Reviewable:

coraliefeil commented 1 month ago

@auroraVasconcelos I refined the design docs based on code docs rewrite.

Pls see what you needs to be addressed in code to be in sync.

auroraVasconcelos commented 4 weeks ago

@auroraVasconcelos I refined the design docs based on code docs rewrite.

Pls see what you needs to be addressed in code to be in sync.

Updated

coraliefeil commented 4 weeks ago

Merci! See comments

coraliefeil commented 3 weeks ago

I am not sure if this is a Figma Issue or Code, but in Design we have more padding inside the "Vertical Navigation":

image

FYI: @coraliefeil @MartaPintoTeixeira

"Relaxed" was true in Figma. I’ve turned it off. All good now.

auroraVasconcelos commented 3 weeks ago

Why is that not an one liner?

image

Fixed

smfonseca commented 3 weeks ago

@auroraVasconcelos please reorder the attributes table to be in sync with what is shown below. Also, I think it's worth adding docs for href and target. Thank you

auroraVasconcelos commented 3 weeks ago

@auroraVasconcelos please reorder the attributes table to be in sync with what is shown below. Also, I think it's worth adding docs for href and target. Thank you

coraliefeil commented 3 weeks ago

Here was a typo:

Code-only: Use the ”separated attribute”, to have more than only one action.

coraliefeil commented 3 weeks ago

Pls update: image

auroraVasconcelos commented 2 weeks ago

Pls update: image

Updated

auroraVasconcelos commented 2 weeks ago

Here was a typo:

Code-only: Use the ”separated attribute”, to have more than only one action.

Updated

coraliefeil commented 2 weeks ago

Approved <3