solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
19 stars 3 forks source link

docs: add v4 announcement page and hint on introduction page [skip chromatic] #1368

Closed karlbaumhauer closed 1 week ago

karlbaumhauer commented 2 weeks ago

Description:

Adds announcement to version 4

closes #1366 and https://github.com/solid-design-system/internal/issues/84

Definition of Reviewable:

coraliefeil commented 2 weeks ago

Is this part still in there? Needs to be updated since we now name all of these things templates.

Bildschirmfoto 2024-09-12 um 09 05 25
coraliefeil commented 2 weeks ago

Let’s delete the emojis ... brand does not allow them

karlbaumhauer commented 2 weeks ago

Let’s delete the emojis ... brand does not allow them

removed them... :-(

karlbaumhauer commented 2 weeks ago

Is this part still in there? Needs to be updated since we now name all of these things templates.

Bildschirmfoto 2024-09-12 um 09 05 25

yes. IMO this is part of the change in general. We need to refactor our whole documentation and look for infos we need to adopt.

=> I will create a ticket for that #1369

karlbaumhauer commented 2 weeks ago

@coraliefeil I just added one part to the changes as the rest is more or less just different or more text on the same place.

@auroraVasconcelos & @MartaPintoTeixeira pls have a look into it and let me know if you found anything, we missed to announce.

mariohamann commented 1 week ago

The docs branch shouldn't contain breaking changes. This would lead to problems on npm i or updating, as in regard to semver there are changes implied, that aren't existing. Not sure, why this is needed?

smfonseca commented 1 week ago

After discussing the content of this PR together with @yoezlem and @mariohamann, we were not sure if this was the best way to announce the docs rewrite. We came up with a different approach, therefore I'm closing this PR.