fix: make sd-step-group more accessible

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.

https://solid-design-system.fe.union-investment.de/docs/

Other

21 stars 4 forks source link

fix: make sd-step-group more accessible #1390

Closed mariohamann closed 1 month ago

mariohamann commented 2 months ago

Description:

sd-divider was replaced with borders, as otherwise an hr would have been announced.

Definition of Reviewable:

[ ] Documentation is created/updated
[ ] Migration Guide is created/updated
[ ] E2E tests (features, a11y, bug fixes) are created/updated
[ ] Stories (features, a11y) are created/updated
[ ] relevant tickets are linked

Vahid1919 commented 2 months ago

@mariohamann The vertical orientation does not look great on the Combination story screenshot specifically because decorator styles are not applied in the combination. Otherwise, you can see the line looks & works as expected :)

karlbaumhauer commented 1 month ago

As I have no information about the issue and what has been done in the PR, I cannot review it :)

yoezlem commented 1 month ago

Do we have a Ticket for that?

mariohamann commented 1 month ago

Sorry, this was really more meant as a draft to tackle it with @Vahid1919 and wasn't meant to be reviewed. (Existing) ticket is now added.

coraliefeil commented 1 month ago

Leave review to you @MartaPintoTeixeira

MartaPintoTeixeira commented 1 month ago

Left some feedback on things that are probably not related with the fix. Perhaps we should open a new fix ticket to address those.