Our custom JS in setCustomValidty triggers unnecessary screenshot comparisons for design approval. This creates confusion and additional effort to find relevant changes in a PR.
Eg: Here only 1 component was changed (map-marker), yet these are the screenshot diffs generated.
SetCustomValidty stories should be updated in order to avoid this. (Perhaps they could be removed from the screenshots as well, but that should be discussed with the team)
Where to put the documentation
This affects:
sd-input
sd-checkbox
sd-select
sd-button
DoR
[x] Item has business value
[ ] Item has been estimated by the team
[ ] Item is clear and well-defined
[ ] Item dependencies have been identified
DoD
[ ] Documentation has been created/updated (if applicable)
[ ] Migration Guide has been created/updated (if applicable)
[ ] Relevant stories (Features, A11y) are created/updated
[ ] Implementation works successfully on feature branch
Description
Our custom JS in setCustomValidty triggers unnecessary screenshot comparisons for design approval. This creates confusion and additional effort to find relevant changes in a PR.
Eg: Here only 1 component was changed (map-marker), yet these are the screenshot diffs generated.
SetCustomValidty stories should be updated in order to avoid this. (Perhaps they could be removed from the screenshots as well, but that should be discussed with the team)
Where to put the documentation
This affects:
DoR
DoD
featurebranch