fix: 🤔 missing border when sd-select has not enough space

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.

Other

21 stars 4 forks source link

Closed Vahid1919 closed 1 month ago

Vahid1919 commented 1 month ago

Limited the height of the listbox using an interesting CSS variable I found in the wrapping sd-popup :) --auto-size-available-height. Closes #1042.

coraliefeil commented 1 month ago

Leave review to you @MartaPintoTeixeira

karlbaumhauer commented 1 month ago

@Vahid1919 pls add a screenshot test for this.

Vahid1919 commented 1 month ago

@karlbaumhauer Added a screenshot test

MartaPintoTeixeira commented 1 month ago

Please check my comment in Chromatic