search

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/docs/
Other
21 stars 4 forks source link

fix: 🤔 sd-display main size variant #1412

Closed yoezlem closed 1 month ago

yoezlem commented 1 month ago

Description:

The default size variant in code is now changed to 4xl. Closes https://github.com/solid-design-system/solid/issues/1355.

Definition of Reviewable:

karlbaumhauer commented 1 month ago

@yoezlem isn't that a breaking change?

yoezlem commented 1 month ago

@yoezlem isn't that a breaking change?

not sure 🤔

@mariohamann @smfonseca ?

auroraVasconcelos commented 1 month ago

@yoezlem isn't that a breaking change?

not sure 🤔

@mariohamann @smfonseca ?

Hey @yoezlem I believe this is a breaking change considering that if you are using the component with the default size you would need to change the code since the default size is now different.

(Issue link)[https://github.com/solid-design-system/solid/issues/1355] we opened an issue for this when we start re-writting this component, probably we have duplicated issues now fixed by this PR.

smfonseca commented 1 month ago

Yes, this is a breaking change imo. It will affect the visual design of the applications where the component is used.

yoezlem commented 1 month ago

Changed main branch to feat/breaking-changes