search

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
19 stars 3 forks source link

feat: ✨ add vertical variant to sd-copyright #1414

Open yoezlem opened 1 week ago

yoezlem commented 1 week ago

Description:

Created now a vertical variant for sd-copyright and marked horizontal as default. Closes https://github.com/solid-design-system/solid/issues/1319.

Definition of Reviewable:

yoezlem commented 1 week ago

@coraliefeil @MartaPintoTeixeira we need the new variant also now as attribute in figma.

Vahid1919 commented 1 week ago

@yoezlem I think we should also include a story for the new attribute.

yoezlem commented 1 week ago

@yoezlem I think we should also include a story for the new attribute.

@Vahid1919 Added.

coraliefeil commented 5 days ago

The © is still displayed with an incorrect rotation. Pls fix.

coraliefeil commented 5 days ago

@coraliefeil @MartaPintoTeixeira we need the new variant also now as attribute in figma.

Will be handled via https://github.com/solid-design-system/solid/issues/1309

yoezlem commented 3 days ago

The © is still displayed with an incorrect rotation. Pls fix.

@coraliefeil fixed it. Please check it again. Thx!