solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/docs/
Other
23 stars 4 forks source link

feat[dev]: ✨ implement A11y improvements for Input Template #1520

Open yoezlem opened 1 month ago

yoezlem commented 1 month ago

Description

This task describes the Storybook implementation for the Input template as part of the A11y improvements outlined in Epic https://github.com/solid-design-system/solid/issues/1465.

A11y improvements for the Input template can be found here: Input Notes.


Comment

See @sd-input

Additional Information

DoR

DoD

MartaPintoTeixeira commented 3 weeks ago

@smfonseca on the input "Type" section the please make sure all copy bellow input starts with Capital letter. ex: Default type

MartaPintoTeixeira commented 3 weeks ago

@smfonseca please check figma docs. We have a section called "Icon" and should have it as well in storybook.

MartaPintoTeixeira commented 3 weeks ago

@smfonseca for the samples of "Type" can you make sure they have the same content as in figma please?

ex: Date ---- "01.03.2025" inside the input ...

MartaPintoTeixeira commented 3 weeks ago

For invalid sample in figma we have "Placeholder text" inside the input

MartaPintoTeixeira commented 3 weeks ago

Can we change the max lengh to 25 please? "25 is the maximum allowed characters"

MartaPintoTeixeira commented 3 weeks ago

For the Spin Buttons in the sample instead of "Min value is 0 and max is 10" can we have "Min value is 0 and max value is 10" to be more splicit?

MartaPintoTeixeira commented 3 weeks ago

Help Text samples should say:

Help text attribute Help text slot

smfonseca commented 3 weeks ago

@MartaPintoTeixeira all comments are addressed in code. Also left you some comments in Figma.

MartaPintoTeixeira commented 3 weeks ago

Approved