fix: 🤔 sd-select placeholder font color is too light - Githubissues

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.

https://solid-design-system.fe.union-investment.de/x.x.x/storybook/

Other

20 stars 4 forks source link

fix: 🤔 sd-select placeholder font color is too light #1539

Open MartaPintoTeixeira opened 3 weeks ago

MartaPintoTeixeira commented 3 weeks ago

Current behavior

The sd-select Placeholder font-color is diferent in code and in figma.

Expected behavior

In figma sd-select Placeholder font-color is neutral-700

Steps to reproduce

Open forms template and compare select item in figma and storybook.

Technical Information

DoR

[ ] Item has business value
[ ] Item has been estimated by the team
[ ] Item is clear and well-defined
[ ] Item dependencies have been identified

DoD

[ ] Documentation has been created/updated (if applicable)
[ ] Migration Guide has been created/updated (if applicable)
[ ] Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
[ ] Relevant stories (Features, A11y) are created/updated
[ ] Implementation works successfully on feature branch

coraliefeil commented 4 days ago

@mpantuso you did not mention this color issue as far as I can see. Or?

Should be fixed within the a11y issues though. So I labeled it with "A11y Audit" @yoezlem