search

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/docs/
Other
23 stars 4 forks source link

discuss: variant names in sd-badge #1545

Open karlbaumhauer opened 1 month ago

karlbaumhauer commented 1 month ago

Problem:

In the docs, it says that the success and error variants don't imply any semantic meaning. They kinda do because they tell me that something good, bad, or neutral is going on. [...]

Discussion so far:

@coraliefeil The color of sd-badge should not tell that sth good, bad or neutral is going on. Plattforms can simply decide which color they would like to use depending on how important a badge should appear.

(See reference https://atlassian.design/components/badge/examples, https://m3.material.io/components/badges/overview

Only sd-status-badge is communicating a certain meaning.

matuzo Okay but the values of the variant attribute (error and success) and the associated colors imply meaning.

Idea/approach/suggestion

We need to rename the variants with a more generic/semantic value in order to keep the colors flexible (sikinning) but remove the semantic meaning.

coraliefeil commented 1 week ago

@smfonseca is this still an issue or didn’t we solve this already when fixing the a11y issue in sd-badge?

smfonseca commented 1 week ago

@coraliefeil the variants still need to be renamed and there is a ticket that I created when we had our discussion. @karlbaumhauer I guess this ticket is not needed since we already have another.