solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/docs/
Other
23 stars 4 forks source link

fix: improve sd-textarea a11y [skip chromatic] #1642

Closed paulovareiro29 closed 2 days ago

paulovareiro29 commented 1 week ago

Description:

Closes #1492

Goals:

Definition of Reviewable:

github-actions[bot] commented 1 week ago

🚀 Storybook has been deployed for branch fix_improve-sd-textarea-a11y

paulovareiro29 commented 1 week ago

Some fields are invalid even when not touched, e.g. required or min-length fields are invalid when not touched, since it is empty, but in this cases the aria-invalid should not show, since the user might still be working to fill in the field.

Now aria-invalid="true" only shows when the field in is also a visual invalid state. This is controlled by showInvalidStyle attribute.

paulovareiro29 commented 1 week ago

The previous change broke the tests I had done, just pushed a change to fix the tests... It is rather annoying that the tests quality gate is always falling.

MartaPintoTeixeira commented 1 week ago

the margin between the help-text and the text area and the margin between the error message and the text area is not consistent. will create a ticket to solve this issue in both figma and dev

MartaPintoTeixeira commented 4 days ago

Where it says: Related templates: Tooltip

change it to: Related templates: Textarea with Tooltip

MartaPintoTeixeira commented 4 days ago

for the invalid sample instead of "Error message" lets have "Error text" as in figma

MartaPintoTeixeira commented 4 days ago

for the disabled section the content inside the textarea should be neutral-500 and is neutral-700. let me know if this is an issue in the component. if so please open a ticket to fix it and align with figma.

paulovareiro29 commented 3 days ago

@MartaPintoTeixeira Issue has been created to address the disabled text color #1661