search

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/docs/
Other
23 stars 4 forks source link

chore!: replace ui-placeholder-video with sds-placeholder-video #1657

Closed paulovareiro29 closed 1 week ago

paulovareiro29 commented 1 week ago

Description:

BREAKING CHANGE: The ui-placeholder-video.mp4 has been deleted and replaced by sds-placeholder-video.webm.

This PR addresses replacing the current placeholder video with the SDS awards video. The decision was made on #1644

Definition of Reviewable:

github-actions[bot] commented 1 week ago

🚀 Storybook has been deployed for branch chore!_replace-placeholder-video

mariohamann commented 1 week ago

You should never write the release message in the commit, this is handled by Semantic Release in the upcoming release then.

paulovareiro29 commented 1 week ago

You should never write the release message in the commit, this is handled by Semantic Release in the upcoming release then.

@mariohamann Do you mean the (release/placeholders)?

Also, shouldn't the PR name have the ! in the name? Or does just having BREAKING CHANGE on the PR description is enough?

You also named it as fix. Why such decision?

mariohamann commented 1 week ago

It has to be either fix or feat, otherwise it doesn't/shouldn't trigger a release. A chore task is not release relevant, as not something that is important for the enduser.

As long as you commit the description along, it's fine to just have it in the message.

Sidenote: We will change things regarding our releases soon with the switch to Changesets.

paulovareiro29 commented 1 week ago

As far as I understand from the commitlint docs, as long as there is a BREAKING CHANGE mentioned, it will trigger a major release.

Reference BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with [MAJOR](http://semver.org/#summary) in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.

paulovareiro29 commented 1 week ago

UPDATE: An agreement was made with @mariohamann to leave the PR as a chore, even if we are introducing a new image now. This is to test how the semantic release will behave by using chore and breaking change.