Open karlbaumhauer opened 10 months ago
Refine ... look at flatpicker ... sync with dev next week
Pls review @EllaELSA -> only the new stylings for date and range ... the other stuff is not refactored yet
Is this a design ticket? Can we mark this with a figma
label?
@abudd1094 Could you please review the design component? I think you're most into what's possible and what not. It would be nice if you could align some props (if possible) to have flatpickr names stuff. But we shouldn't overforce that here, as we won't provide a component in the end.
Is this a design ticket? Can we mark this with a
figma
label?
@mariohamann from my perspective, this is the design ticket to define the component, which will be build in #273
I think it is too early to review ... presenting design draft to brand on Thursday.
Hi @abudd1094 , could you help me review this, pls? https://www.figma.com/file/9hJu09NkrkaPJKIe6eC5uk/sd-datepicker?type=design&node-id=401-2293&mode=design Thank you
We are mixing up our concepts and language around the Datepicker. It is referred to in the tickets and comments as a “component”. I am seeing words like “slot” and “props”. There is no component, there are no slots, there are no props. This feels like a continuation of the research discussion
From the previous discussions, we have said we will provide:
It feels to me like we are reaching for a simple solution and overcomplicating it. Flatpickr simply does not seem to promote extensive customization and certainly does not have the supporting documentation to make that process easy. It will be a hack job and the considerations outlined above should be carefully thought over before finalizing any designs.
I would do one of the following:
@abudd1094 This ticket here focuses design, and they need some kind props etc. Still thanks for your updated thoughts on Flatpickr...
Handing this one over to you for review. Thanks a lot.
I would second @abudd1094 what he said in the Figma file: Remove everything what indicates, that we have a web component for that. It feels more like a "helper component" so that people can build their thing easier. So we shouldn't call it sd-datepicker, maybe it's even more a template or pattern with a helper-component? Or we show it as a sample of the input-component? And there we provide the theme in Storybook as well? In that case, you wuld be pretty free how to name the stuff – but as said, remove things like <slot>
etc. and make very clear, that thit is NOT a component.
Does this help you enough, @coraliefeil ?
"Datepicker is no longer a dedicated webcomponent but a sd-input sample offered in Figma as a helper component and in Storybook as a theme developers can add to sd-input and customize as desired."
@mariohamann Please check briefly whether this is sufficient to start coding.
Thanks!
I believe we decided to start working on it in development, so I would propose to close this ticket and leave the current state as is. Fine for you @coraliefeil?
Great. Then I would label it with waiting for dev and publish when code is ready.
Handing this one to you @van-nguyen-ht so you can publish when code is ready.
User Story
As a consumer/stakeholder of the Solid Design System, I would like to utilize a clear and understandable design concept for the calendar so that designing and coding is effective.
Please note
Datepicker is no longer a dedicated webcomponent but a sd-input sample offered in Figma as a helper component and in Storybook as a theme developers can add to sd-input and customize as desired.
Component name and version number:
sd-input/sample-datepicker V.1.0.0 (Replaces sd-datepicker V.0.0.1)
Figma Branch
Components detailed requirements
DoR
DoD
figma
branch