search

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
20 stars 4 forks source link

feat: ✨ add multi selected label property to `sd-select` #746

Open karlbaumhauer opened 8 months ago

karlbaumhauer commented 8 months ago

User Story

As a user of the Solid Design System, I would like to have the possibility of adding a custom label to the sd-select in case multiple options are selected, so that I am more flexible to tell the users what exactly they selected (eg. categories).

Suggested Solution

A new optional property called multiselect-placeholder (default: none) should be added and overwrite the existing default string "Options Selected (#)".

Note: it needs to be a string property as the # will be dynamically replaced and only the first part "Options Selected" is localized. We also need to make sure (documenting) that the users are aware of the fact, that i18n will be obsolete as soon as they set a custom value.

Note 2: Jira Task No. 21 needs to be closed as well.

DoR

  • [ ] Item has business value
  • [ ] Item has been estimated by the team
  • [ ] Item is clear and well-defined
  • [ ] Item dependencies have been identified

DoD

karlbaumhauer commented 8 months ago

@coraliefeil do we need to change this in Figma as well or is it already possible?

coraliefeil commented 8 months ago

Can be overriden in figma ... I added it to the docs

https://www.figma.com/file/ZphyVFsUHL72voMrJagMeo/Select?type=design&node-id=1636-2080&mode=design&t=hvchPIQ4TjuGTvxg-11

karlbaumhauer commented 8 months ago

perfect. thx.

yoezlem commented 7 months ago

Blocked by: https://github.com/solid-design-system/solid/issues/852

mariohamann commented 3 weeks ago

This was solved via #852 and is even documented here: https://solid-design-system.fe.union-investment.de/x.x.x/storybook/?path=/docs/docs-general-localization--docs#programmatic-localization

I added a new ticket, to fix some little things that occured during my implementation and which would pay into that ticket.

@yoezlem This one could therefore be closed.

mariohamann commented 3 weeks ago

Here is the new ticket: https://github.com/solid-design-system/solid/issues/1536

Feel free to put it into the refinement.

karlbaumhauer commented 3 weeks ago

I already closed the respective Jira ticket.