search

solid-design-system / solid

Monorepo for Union Investment's Solid Design System.
https://solid-design-system.fe.union-investment.de/x.x.x/storybook/
Other
19 stars 3 forks source link

ci: 👷 update icon sets #990

Open coraliefeil opened 5 months ago

coraliefeil commented 5 months ago

User Story

As a consumer of the Solid Design System, I would like to utilize an icon set in figma and storybook that is always up to date, so that I’m not missing out on new icons that have been added to celum.

Suggested Solution

Generate an automatic info when new icons have been added to celum and export them so they can be added to Figma manually. Is there an automatic process into Storybook possible?

Environment (GitHub Actions or Azure DevOps)

Technical Information

DoR

DoD

coraliefeil commented 5 months ago

I’m assigning this one to you for further handling. ATM we have two new system icons: transcript and arrow-up-down October last year was the last point in time where we have been in sync with celum & toolbox. After that we only updated the few icons we needed for component builts. THX ;)

coraliefeil commented 4 months ago

Would it be possible for you @karlbaumhauer to

  1. handover a list of icons that have been added to celum since October last year, pls?
  2. generate an automatic information e.g. once a week that lists all new icons?
karlbaumhauer commented 4 months ago

@coraliefeil I remember the CMS team working on someting like this. I will try to clarify asap.

coraliefeil commented 4 months ago

In addition we need to also know if file name have been changed. Not only if new icons are added.

karlbaumhauer commented 4 months ago

@coraliefeil I stressed the topic in the respective team and wait for feedback. We are not the only team with this request.

coraliefeil commented 4 months ago

[like] Coralie Deutscher reacted to your message:

From: Karl Baumhauer @.> Sent: Thursday, May 23, 2024 2:33:36 PM To: solid-design-system/solid @.> Cc: Coralie Deutscher @.>; Mention @.> Subject: Re: [solid-design-system/solid] ci: 👷 update icon sets (Issue #990)

@coraliefeilhttps://github.com/coraliefeil I stressed the topic in the respective team and wait for feedback. We are not the only team with this request.

— Reply to this email directly, view it on GitHubhttps://github.com/solid-design-system/solid/issues/990#issuecomment-2127283424, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ7UDVHU5GNF57N4GBMKKBTZDX44BAVCNFSM6AAAAABGZOA4OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXGI4DGNBSGQ. You are receiving this because you were mentioned.Message ID: @.***>

coraliefeil commented 1 month ago

Update:

Info from Brand - Celum icons now use the new green color

coraliefeil commented 1 month ago

@mariohamann could you pls add your thoughts we just talked about? THX