search

solid-software / solid_lints

🟧 Lints for Dart and Flutter based on software industry standards and best practices.
Other
36 stars 18 forks source link

Update `analyzer` dependency #104

Closed ghost closed 8 months ago

ghost commented 8 months ago

Is this behaviour expected?
Seems like a bug.

Screenshot 2024-01-19 at 16 23 47

We have two linter warnings around one function: the one right before the 'void' keyword and second near brackets.

Screenshot 2024-01-19 at 16 22 12

yurii-prykhodko-solid commented 8 months ago

Is this behaviour expected?

@solid-daniilmarchenko yeah looks like a bug -- could be stemming from the fact that we're checking both function declaration and function body -- where one contains another, IIRC. Maybe just check function bodies? Give it a try.

ghost commented 8 months ago

it looks like we really don't need FunctionDeclaration but removing it doesn't really fix all of the warning duplications. i've tried to check other node types (including the BlockFunctionBody) that we could use instead of the current ones but it doesnt look to work fine anyway.