solid / notifications

Solid Notifications Technical Reports
https://solid.github.io/notifications/protocol
MIT License
11 stars 7 forks source link

Define WebPushSubscription2022 type for Solid Notifications #64

Closed uvdsl closed 2 years ago

uvdsl commented 2 years ago

Dear all,

I propose a first draft for defining the WebPushSubscription2022 type, based on my original submission, as decided in the Notifications Panel meeting on 2022-03-22 (see https://github.com/solid/notifications-panel/pull/52).

This PR addresses #35.

While writing this draft, I noticed that several existing issues need to be resolved prior to finishing this draft, including but not limited to #36, #62 and #63.

I deeply appreciate any feedback.

elf-pavlik commented 2 years ago

I will review it this weekend, meanwhile, I pushed your branch to my fork so that GitHub action renders it. I still need to set up the rendering preview for each PR. Preview of this branch at d5ff597 is available here: https://elf-pavlik.github.io/notifications/webpush-subscription-2022