I was unable to continue working on this repo, possibly after updating MacOS and/or my Ruby version. Since this repo does not indicate supported platforms/versions, I tried to set up some acceptable minima.
Recent guides to installing ruby (including the jekyll docs linked to in the README) typically use the latest 3.1.x or 3.2.x release [1]. Moreover, versions <3.1 also don't work well with MacOS Command Line Tools >14 [2].
In upgrading from 3.1 to 3.2, however, support for nokogumbo is lost, since this gem has already been integrated into nokogiri for a few years [3]. To prevent this becoming an issue in the future, we should migrate to html-proofer ~>5 [4] (since we have to bump a major version, might as well skip to the latest).
Using ruby >=3.1 with bundler <2.3.4 also leads to a deprecation warning because of an inconsistency in their respective did-you-mean and thor dependencies [5]. This is another slight nudge towards using ruby >=3.2 with bundler >=2.3.4.
What this PR does:
Add ruby >=3.2 as a minimum in the Gemfile. Since Netlify has an older version, I left this out. Can we switch Netlify to a newer one?
Add a check for bundler >=2.3.4 to the Gemfile.
Add ~>5 as version specifier to html-proofer in the Gemfile.
Update the lockfile with bundle update html-proofer --bundler --conservative
Update the README to mention these new version requirements for tooling.
As an aside: made a minimal syntax change in _config.yml, to get rid of a deprecation warning of jekyll.
I was unable to continue working on this repo, possibly after updating MacOS and/or my Ruby version. Since this repo does not indicate supported platforms/versions, I tried to set up some acceptable minima.
Recent guides to installing
ruby(including thejekylldocs linked to in the README) typically use the latest3.1.xor3.2.xrelease [1]. Moreover, versions<3.1also don't work well with MacOS Command Line Tools>14[2].In upgrading from 3.1 to 3.2, however, support for
nokogumbois lost, since this gem has already been integrated intonokogirifor a few years [3]. To prevent this becoming an issue in the future, we should migrate tohtml-proofer ~>5[4] (since we have to bump a major version, might as well skip to the latest).Using
ruby >=3.1withbundler <2.3.4also leads to a deprecation warning because of an inconsistency in their respectivedid-you-meanandthordependencies [5]. This is another slight nudge towards usingruby >=3.2withbundler >=2.3.4.What this PR does:
AddSince Netlify has an older version, I left this out. Can we switch Netlify to a newer one?ruby >=3.2as a minimum in the Gemfile.Add a check for
bundler >=2.3.4to the Gemfile.Add
~>5as version specifier tohtml-prooferin the Gemfile.Update the lockfile with
bundle update html-proofer --bundler --conservativeUpdate the README to mention these new version requirements for tooling.
As an aside: made a minimal syntax change in
_config.yml, to get rid of a deprecation warning ofjekyll.[1] https://jekyllrb.com/docs/installation/macos/ [2]https://www.moncefbelyamani.com/how-to-install-xcode-homebrew-git-rvm-ruby-on-mac/ [3] https://github.com/rubys/nokogumbo#notice-end-of-life, https://nokogiri.org/CHANGELOG.html#fixed_18, https://github.com/sparklemotion/nokogiri/issues/2205 [4] https://github.com/gjtorikian/html-proofer/pull/650, https://github.com/gjtorikian/html-proofer/pull/674 [5] https://github.com/rubygems/rubygems/issues/5234, https://github.com/rubygems/rubygems/blob/master/bundler/CHANGELOG.md#231-december-22-2021