search

solidify / devops-extension-chuck-norris

Chuck Norris Azure DevOps build enhancer
13 stars 2 forks source link

Wish: Separate Quote types based on success / failed #10

Open patdaman opened 5 years ago

patdaman commented 5 years ago

It would be great if the quote type related to the success / failure of the build.

I haven't yet seen an environment variable for success / failure while executing, only as a condition for the task to execute or not. Previous tasks to this one would output a non success, not sure if we need to save the output or search for $($env:ErrorMessage) in the running log.

I would love him to talk smack if the build failed!

MOlausson commented 5 years ago

I like the idea. Just to make sure I get this right, you would like a way to control so that Chuck only is shown when builds fail?

patdaman commented 5 years ago

That's another idea, a configuration option to only display for failed, successful, or both. I like that. Failed builds are also more likely to be inspected!

What I meant was to have two separate 'buckets' of quotes; one bucket for successful builds (or no errors to that point), and another bucket with quotes for when the build fails (or has a preceding error).

That way he can say something in the list more specific for a failed build like: "“It works on my machine” always holds true for Chuck Norris."

All other categories reserved for successful builds.

Kind of having Chuck taunting the developers.

MOlausson commented 5 years ago

Ok, got it. Sounds like a good idea. Have a look here and would appreciate your help categorizing the jokes (or add more if you're up to it!): https://github.com/solidify/devops-extension-chuck-norris/blob/362bb6ce5af74dcbdaf30f13853fc83ad57225ae/src/enhancer/buildResults.ts#L15

patdaman commented 5 years ago

I sure will!

Thanks

MOlausson commented 5 years ago

@patdaman did you get to look at this?