There was a race between printing to stderr and the cleanup function clearing the current cursor line. This PR removes atomic shared ownership of the progress indicator and instead passes around a channel so that all requests to run a cleanup funnels to a single location: The progress indicator's thread.
We then join that thread to the main-thread before printing any sort of output whether it be an error message or the actual result.
This is better design overall and I should have done this from the start.
Closes https://github.com/solidiquis/erdtree/issues/219
Summary
There was a race between printing to stderr and the cleanup function clearing the current cursor line. This PR removes atomic shared ownership of the progress indicator and instead passes around a channel so that all requests to run a cleanup funnels to a single location: The progress indicator's thread.
We then join that thread to the main-thread before printing any sort of output whether it be an error message or the actual result.
This is better design overall and I should have done this from the start.