solidjs-community / eslint-plugin-solid

Solid-specific linting rules for ESLint.
MIT License
220 stars 27 forks source link

Adding support for ESlint 9.0.0 #136

Closed AlbertSabate closed 5 months ago

AlbertSabate commented 5 months ago

ESLint 9.0.0 has been released as stable.

Currently, the ESlint version of this package is pointing to version 8.43.0, which has many deprecation notices for version 9.0.0.

This version updates the code to prevent using deprecated fn from version 8.x and start using the new fns of 9.x

The version has been updated to 8.56.0 and migrated to a non-deprecated FNS.

ESLint has not been bumped to version 9, as many changes are required to maintain backward compatibility. However, the package works well in the new version.

Tests are passing. And I tested a bit on my end. This is not a guarantee that I did not break anything. And Code reviews will be really appreciated :)

Note that the package has been bumped to 0.14.0.

Issue: https://github.com/solidjs-community/eslint-plugin-solid/issues/137

joshwilsonvu commented 5 months ago

Hi, thank you for putting together a PR for this. Looking more into this, it's going to take a fair amount of changes to support ESLint v9 in a backwards-compatible way, since ESLint did not provide backwards-compatibility for the moved APIs.

Like I said in the issue, I don't want to drop support for < v9, so I'm going to make the required changes in another PR (#140). As with most ESLint plugins, it's going to take some time to support the new major. (pnpm test:all checks the plugin across different versions/parsers, and I'd like to get them all passing for v6–v9.)

In the meantime, I hope you and others are able to use your fork with ESLint v9 🙂 I hope you don't mind if I close this—we can reopen should you get to a non-breaking change, but I should have it covered. Thank you again for your PR!

joshwilsonvu commented 5 months ago

eslint-plugin-solid is now compatible with ESLint 9 in v0.14.0! Please let me know if you have any issues.

Nixie24 commented 5 months ago

eslint-plugin-solid is now compatible with ESLint 9 in v0.14.0! Please let me know if you have any issues.

It sounds awesome.I'll try it later.🎉