search

solidjs-community / eslint-plugin-solid

Solid-specific linting rules for ESLint.
MIT License
216 stars 26 forks source link

reactivity: derived signals should be allowed as getters #18

Closed otonashixav closed 2 years ago

otonashixav commented 2 years ago

Describe the bug I note that the reactivity docs mention:

This rule ignores object and class methods completely. Solid is based on functions/closures only, and it's uncommon to see methods in Solid code.

However, with getters this is not the case. The docs suggest using getters as derived values in stores: https://www.solidjs.com/docs/latest/api#getters.

Expected behavior Getter should not warn.

Screenshots image

Additional context Discord

joshwilsonvu commented 2 years ago

This is fixed in v0.4.7, thanks for the report!