solidjs-community / eslint-plugin-solid

Solid-specific linting rules for ESLint.
MIT License
220 stars 27 forks source link

Fix onDblClick -> onDoubleClick, put spread event handler warning behind a flag #47

Closed joshwilsonvu closed 1 year ago

joshwilsonvu commented 1 year ago

Closes #46. I inadvertently enforced React's special double click event instead of the standard dblclick event. This PR makes that no longer a warning and automatically corrects onDoubleClick back to onDblClick.

With Solid's improvements to JSX spreading in v1.6, there's now no need to warn when spreading an event handler into JSX, at least one that's statically analyzable. The part of the solid/event-handlers rule that warned on this is now behind an option, warnOnSpread.