search

solidjs-community / eslint-plugin-solid

Solid-specific linting rules for ESLint.
MIT License
209 stars 24 forks source link

Silence reactivity warnings in (standard Web APIs) `*Observer` callbacks #82

Closed macarie closed 1 year ago

macarie commented 1 year ago

This should fix #81.

I don't have much experience building eslint rules, so I don't know if this is the right approach, but it seems to be working and doesn't break any existing tests.

If you don't think these warnings should be silenced, please, feel free to close the PR!

joshwilsonvu commented 1 year ago

Thanks for the contribution! You're absolutely right that these Observer callbacks should be handled by the rule in the same way as timers. I'll go ahead and get this merged shortly. 🎉