search

solidjs-community / solid-aria

A library of high-quality primitives that help you build accessible user interfaces with SolidJS.
Other
289 stars 16 forks source link

Move utils/platform to @solid-primitives/platform #23

Closed thetarnav closed 2 years ago

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: be9d4c4e2178143379e0f709ed4c573400ddff87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fabien-ml commented 2 years ago

Do all tests pass with the change ?

thetarnav commented 2 years ago

Do all tests pass with the change ?

now they do, lol I got too used to relying on gh action tests, so I only tested with the build command. But I had to change the way isIOS variable was being mocked in createPress tests. Since the variable is not a function anymore, it cannot be done by modifying the window.navigator on the fly.