search

solidjs-community / solid-aria

A library of high-quality primitives that help you build accessible user interfaces with SolidJS.
Other
289 stars 16 forks source link

Setup SSR testing #43

Closed thetarnav closed 2 years ago

thetarnav commented 2 years ago

Having automatic tests specifically for SSR should help ensure that solid-aria can be used with solid-start without trouble. Not that it's certain that it'll run, we've seen that there are a lot of random things, especially with jsx transform that could go wrong. But the API itself should benefit from this.

Should I add a changeset for all packages, or only the updated utils?

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 489f9f136eb790f9a9dea7d0d2e75ec17bb3b644

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fabien-ml commented 2 years ago

I don't think there is a need to release for now, maybe when we have more component related primitives done. I've set the release action manual btw.