search

solidjs-community / solid-aria

A library of high-quality primitives that help you build accessible user interfaces with SolidJS.
Other
289 stars 16 forks source link

remove `props.children` from button readme #67

Closed thetarnav closed 2 years ago

thetarnav commented 2 years ago

Children are being passed down with the buttonProps, no need to apply them twice.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 2201b81a5b4b98de52838d00efed77c89c277d80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

thetarnav commented 2 years ago

Actually because of #69 it doesn't actually work xd