search

solidjs-community / solid-aria

A library of high-quality primitives that help you build accessible user interfaces with SolidJS.
Other
289 stars 16 forks source link

chore: replace `rollup` with `tsup` in some packages #76

Closed amirhhashemi closed 2 years ago

amirhhashemi commented 2 years ago

I believe this resolves #75

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: f3d66d8983ee76e992977822760be22805faa9c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fabien-ml commented 2 years ago

Hi, thanks for the PR.

However, packages that contains jsx must use rollup to ship precompiled jsx in order to works with solid-start so we can't use tsup here.

amirhhashemi commented 2 years ago

Oh I didn't know that.