solidjs-community / solid-transition-group

SolidJS components for applying animations when children elements enter or leave the DOM.
https://solid-transition-group.netlify.app
MIT License
254 stars 14 forks source link

add update animation name feature #17

Closed MFrozenM closed 2 years ago

MFrozenM commented 2 years ago

When you want to update the animation name in Transition, it doesn't work.

<Transition name={animation}> {active() === 0 && <Component/>} </Transition>

The problem was mergedProps. It doesn't update when we pass a new name with props. So, I remove it, declare the classes with let, and handle name changes in createEffect.