search

solidjs-community / strello

54 stars 1 forks source link

More fine grained optimistic updates using `produce` #17

Closed devagrawal09 closed 3 months ago

devagrawal09 commented 3 months ago

Split the board store updating effect into two, one that only applies optimistic updates using produce, and one that resets the board from server data using reconcile

devagrawal09 commented 3 months ago

I'll take a look at the bug tonight, we can merge this once it's fixed. Thanks @brenelz,

netlify[bot] commented 3 months ago

Deploy Preview for strello ready!

Name Link
Latest commit cf7c63c364733648ec24455c4eedb53ec03bd40d
Latest deploy log https://app.netlify.com/sites/strello/deploys/66cea862877892000869c80f
Deploy Preview https://deploy-preview-17--strello.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

devagrawal09 commented 3 months ago

Fixed

Turns out that filtering the mutations by timestamp on getting fresh server data was causing the inconsistency issue

I was filtering by timestamp there to solve an issue where adding a note ended up showing that note twice, because the optimistic update for that note was being applied on top of fresh data with that note already added. Found a different (and better) fix for this issue - check if the note is already present in the list before adding it.