search

solidjs / react-solid-state

Auto tracking state management for modern React
MIT License
190 stars 5 forks source link

Expected 2 arguments on createEffect #1

Open grappleware opened 3 years ago

grappleware commented 3 years ago

TypeScript complains that createEffect should have 2 arguments. I believe the following should work without issue:

const [someSignalValue, setSomeSignalValue] = createSignal("foo");

createEffect(() => { 
  console.log(someSignalValue());  // will log "foo"
});

However, the type definition says that there should be a second argument for a value. I'm not sure why this second argument is required or even what it does. Is it a dependency? And if so, shouldn't it be optional since someSignalValue() is automatically tracked?

Maybe I'm misunderstanding. Thanks!

ryansolid commented 3 years ago

I didn't actually do the typing for this repo, it was community driven and admittedly I haven't used this in a TS based project yet. If it has a type error with the 2nd argument missing that sounds like a bug with the types. The signatures should really be exporting same types as the main Solid repo.