add bubble-reactivity - Githubissues

solidjs / signals

MIT License

144 stars 4 forks source link

add bubble-reactivity #6

Closed milomg closed 1 year ago

milomg commented 1 year ago

Current failing tests:

2 tests failing because of a new error about reading disposed computations
2 tests failing because of describe which isn't working in the current vitest version for some reason

One awkward thing: This required changing bubble-reactivity to run effects synchronously on creation which seems a bit backwards given that the rest of the time effects don't run synchronously. Fixing this can be a separate PR though

mihar-22 commented 1 year ago

Looks awesome! You've cleaned up most of the code and added async support it seems. I'd love test that out soon :) Oh, this reminded me there's a bug in disposal with updating head pointer. Simple fix: https://github.com/maverick-js/signals/commit/09ebc3cb4fe50034ad29e3636bdcadcf193d5e04. We need to add here and in bubble.

This line in PR: https://github.com/solidjs/x-reactivity/pull/6/files#diff-ad42748fd532f122b75f1915e93418bba27d2ddd8e5b189f2147f7ad640772bbR82