solidjs / solid-docs-legacy

OLD documentation for SolidJS and related packages, replaced by https://github.com/solidjs/solid-docs-next
https://www.solidjs.com/
MIT License
188 stars 151 forks source link

Update getting-started.md to use esm.sh not skypack #275

Closed vezwork closed 1 year ago

vezwork commented 1 year ago

Summary

The example code in getting-started.md under the buildless options heading does not work because skypack is not working with the latest version of solid (1.8.1). This PR updates the example code to use esm.sh instead of skypack

As discussed in this bug in the main solid repo https://github.com/solidjs/solid/issues/1921, skypack is no longer recommended as a buildless option for solid. Esm.sh is now the recommended option.

Testing

I copied the example code under the buildless options heading to a local html file, replaced the skypack urls with esm.sh ones, and opened the html file in a chromium browser, it ran successfully without errors in the console. I then took this code that I verified to run locally, and updated the example code in getting-started.md with it.

ryansolid commented 1 year ago

I approve of these changes.