Add Show example that preserves an if-condition-then-else structure

solidjs / solid-docs-next

SolidJS Docs.

https://docs.solidjs.com/

208 stars 230 forks source link

Closed martixy closed 2 months ago

martixy commented 2 months ago

Because the current example subverts an expectation practically every programmer has of how conditional statements work:

if condition then
    then-clause
else
    else-clause

I think this is a more usable pattern and it should be highlighted.

stackblitz[bot] commented 2 months ago

Run & review this pull request in StackBlitz Codeflow.

netlify[bot] commented 2 months ago

Name	Link
Latest commit	ed4d33de00d8608cfad1bfd1706393808fb560c9
Latest deploy log	https://app.netlify.com/sites/solid-docs/deploys/66408da0424c0300089913b0
Deploy Preview	https://deploy-preview-714--solid-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LadyBluenotes commented 2 months ago

Hi @martixy, following our discussion in the docs channel, we've decided not to feature this particular pattern in the docs.

However, if you're interested in promoting it through a tutorial or article, we're happy to provide support, if needed.

Thank you!