Default export is required for page components

solidjs / solid-docs-next

SolidJS Docs.

https://docs.solidjs.com/

208 stars 225 forks source link

Closed klequis closed 1 month ago

klequis commented 1 month ago

In my testing having a non-default export:

export function ComponentName() {}

Results in the route not being found. (goes to the catch-all)

Therefore, I'm suggesting replacing "should" with "must".

stackblitz[bot] commented 1 month ago

Run & review this pull request in StackBlitz Codeflow.

netlify[bot] commented 1 month ago

Name	Link
Latest commit	2904616ad1bcef2163c7a93ece7d0b763abd47ab
Latest deploy log	https://app.netlify.com/sites/solid-docs/deploys/6659f766eda1e1000857164a
Deploy Preview	https://deploy-preview-759--solid-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.