solidjs / solid-docs-next

SolidJS Docs.
https://docs.solidjs.com/
208 stars 225 forks source link

[Content]: Incorrect explanation of `isSVG` on <Portal> #767

Open jer3m01 opened 1 month ago

jer3m01 commented 1 month ago

📚 Subject area/topic

Reference

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/reference/components/portal

📋 Description of content that is out-of-date or incorrect

[...] and isSVG is required if inserting into an SVG element so that the <div> is not inserted.

Should be replaced by something like

so that a <g> is inserted instead of a <div>.

Source: https://github.com/solidjs/solid/blob/b5a379f889e8f7a208bc223b908a0fdcf353d944/packages/solid/web/src/index.ts#L87C27-L87C81

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response