search

solidjs / solid-docs-next

SolidJS Docs.
https://docs.solidjs.com/
208 stars 225 forks source link

Metaprovider included in docs #773

Open Souvlaki42 opened 4 weeks ago

Souvlaki42 commented 4 weeks ago

I think that the examples in the docs for head and metadata should include that you need to wrap the title in MetaProvider because otherwise a <MetaProvider /> should be in the tree error will get thrown at you when you save your file. I thought not worthing opening an issue, so I just added it myself there.

stackblitz[bot] commented 4 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

netlify[bot] commented 4 weeks ago

Deploy Preview for solid-docs ready!

Name Link
Latest commit bb1964409a8a2da3cdbd64b60a198a045f9d55ac
Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/666a29faf772d00008bf9b73
Deploy Preview https://deploy-preview-773--solid-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Souvlaki42 commented 4 weeks ago

I forgot to change which line should be highlighted in each example. It should be fixed now.