search

solidjs / solid-docs-next

SolidJS Docs.
https://docs.solidjs.com/
208 stars 225 forks source link

Catch-all parameters description change #779

Closed klequis closed 3 weeks ago

klequis commented 3 weeks ago

From the users perspective the value returned by useParms in the params object is a string, not an array. I think it is better to speak about the string which is returned rather than the array you can see if you insect the params proxy object with Object.entries.

Additionally, useParams only returns segments after the last valid segment.

I replaced the word "hook" with "primitive" per the writing guide.

I will attach a repo to demonstrate this shortly.

stackblitz[bot] commented 3 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

netlify[bot] commented 3 weeks ago

Deploy Preview for solid-docs ready!

Name Link
Latest commit 22433a117d92391d82a1077f23c99ba03c6c5b8e
Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6671f2944fdaf500081ebca7
Deploy Preview https://deploy-preview-779--solid-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

klequis commented 3 weeks ago

Here is a repo which validates the change. There is some logging to the browser console which may be informative.

https://github.com/klequis/solid-docs-pull-request-779