search

solidjs / solid-docs

SolidJS Docs.
https://docs.solidjs.com/
220 stars 257 forks source link

[Bug]: Core hero shown on Router and Start #637

Open birkskyum opened 6 months ago

birkskyum commented 6 months ago

📝 Issue Description

It's problematic that the Core hero show up on Router and Start, in particular on Mobile where it takes up the full viewport, and the "Get started" button directs to Core which is quite confusing.

📋 On which page(s) it occurs

https://docs.solidjs.com/solid-router + i18n versions https://docs.solidjs.com/solid-start + i18n versions

🤔 Expected Behavior

Either a Router / Start hero, or no hero - just not the Core hero.

👀 Current Behavior

-

🖥️ Browser

Chrome 122

📄 Additional Information

No response

brenelz commented 2 weeks ago

This looks like its already changed?

birkskyum commented 2 weeks ago

Router is still just a solid copy more or less