Closed brenelz closed 1 month ago
Run & review this pull request in StackBlitz Codeflow.
Name | Link |
---|---|
Latest commit | af8cce176a7ac80ddd1af0ac486415c1be131118 |
Latest deploy log | https://app.netlify.com/sites/solid-docs/deploys/66f6d1a77d1d1200081adb55 |
Deploy Preview | https://deploy-preview-901--solid-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Awesome work @brenelz , would you mind adding JS snippets to the code examples?
The module is already injected by default when you need.
The id
of the div is the tab name
eg.:
<TabsCodeBlocks>
<div id="ts">
code block 1, triple backticks - same as you have.
</div>
<div id="js">
code block 2
</div>
</TabsCodeBlocks>
I'm defaulting to TS in front and JS second, because we're aiming for TS snippets to be the source of truth (hopefully one day we automate this step)
Awesome work @brenelz , would you mind adding JS snippets to the code examples? The module is already injected by default when you need. The
id
of the div is the tab nameeg.:
<TabsCodeBlocks> <div id="ts"> code block 1, triple backticks - same as you have. </div> <div id="js"> code block 2 </div> </TabsCodeBlocks>
I'm defaulting to TS in front and JS second, because we're aiming for TS snippets to be the source of truth (hopefully one day we automate this step)
Nice this was pretty simple to add which is nice
Description(required)
Closes a few issues around nested routing. I hope this is more clear.
This requires a more in depth review then the others as its a bit more involved.
Related issues & labels