solidjs / solid-docs

SolidJS Docs.
https://docs.solidjs.com/
224 stars 264 forks source link

Clarify some nested routing things #901

Closed brenelz closed 1 month ago

brenelz commented 1 month ago

Description(required)

Closes a few issues around nested routing. I hope this is more clear.

This requires a more in depth review then the others as its a bit more involved.

Related issues & labels

stackblitz[bot] commented 1 month ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

netlify[bot] commented 1 month ago

Deploy Preview for solid-docs ready!

Name Link
Latest commit af8cce176a7ac80ddd1af0ac486415c1be131118
Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/66f6d1a77d1d1200081adb55
Deploy Preview https://deploy-preview-901--solid-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

atilafassina commented 1 month ago

Awesome work @brenelz , would you mind adding JS snippets to the code examples? The module is already injected by default when you need. The id of the div is the tab name

eg.:

<TabsCodeBlocks>
  <div id="ts">
      code block 1, triple backticks - same as you have.
   </div>
   <div id="js">
       code block 2
    </div>
</TabsCodeBlocks>

I'm defaulting to TS in front and JS second, because we're aiming for TS snippets to be the source of truth (hopefully one day we automate this step)

brenelz commented 1 month ago

Awesome work @brenelz , would you mind adding JS snippets to the code examples? The module is already injected by default when you need. The id of the div is the tab name

eg.:

<TabsCodeBlocks>
  <div id="ts">
      code block 1, triple backticks - same as you have.
   </div>
   <div id="js">
       code block 2
    </div>
</TabsCodeBlocks>

I'm defaulting to TS in front and JS second, because we're aiming for TS snippets to be the source of truth (hopefully one day we automate this step)

Nice this was pretty simple to add which is nice