Update createResource, add "state" field.

solidjs / solid-docs

SolidJS Docs.

https://docs.solidjs.com/

224 stars 264 forks source link

Open klequis opened 2 weeks ago

klequis commented 2 weeks ago

The new state field was documented but not added to the signature.

[ x] I have read the Contribution guide
[ ] This PR references an issue (except for typos, broken links, or other minor problems)

The doc states that a new state field had been added but it did not appear in the createResource signature.

stackblitz[bot] commented 2 weeks ago

Run & review this pull request in StackBlitz Codeflow.

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	9d64740663ee53349a35a3d47c741eb8bcfc1925
Latest deploy log	https://app.netlify.com/sites/solid-docs/deploys/671acc888f300f0008928ac1
Deploy Preview	https://deploy-preview-918--solid-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

klequis commented 2 weeks ago

Someone might want to confirm that "state" belongs in all of the examples vs just some of them. I put it in 4 examples/instances of createResource.